Repository navigation
Conversation
…custom icon tests
…d directions in tests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task done
1 of 2 tasks
brandyscarney
requested changes
Nov 18, 2026
brandyscarney
left a comment
Member
There was a problem hiding this comment.
The feature looks good but can you fix the screenshots?
Member
There was a problem hiding this comment.
The checked toggles are cut off can you fix that?
I think you should be able to use this:
grid-template-columns: auto;
Comment on lines
+37
to
+39
| ion-toggle { | ||
| width: 100%; | ||
| } |
Member
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue number: resolves #30996
What is the current behavior?
Currently, the on/off label icons in
ion-toggleare hardcoded per mode, so there's no way to swap them for something like a sun and moon on a dark mode toggle.What is the new behavior?
checkedIconanduncheckedIconprops toion-toggle, plustoggleCheckedIconandtoggleUncheckedIconglobal config options. The props win over the config, and both fall back to the existing mode defaults. Like the defaults, they only show whenenableOnOffLabelsistrue.ios, the default checked icon is a dash rotated into a vertical line, so a custom checked icon skips that rotation and uses the same size and inset as the unchecked icon.IonToggleinputs, since those aren't generated.Does this introduce a breaking change?
It's a new feature, which is why it's pointed at
feature-9.1.Other information
This is based on the original PR by @AbdullahAhmadAAK. That PR pointed at
main, but new features now go tofeature-9.1, a branch that didn't exist yet when it was opened. Retargeting it would have conflicted, because the generated Angular proxies moved onfeature-9.1, so I remade it fromfeature-9.1instead. Their commit is still there with them as the author. The commits after it fix theioschecked icon size, keep themdicon at its current size and add tests. Thanks to @AbdullahAhmadAAK for getting this started!Custom icons test page (MD)
Custom icons test page (iOS)