Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
requested changes
Nov 18, 2026
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good! Just one issue with the JavaScript example.
| @@ -0,0 +1,10 @@ | |||
| ```html | |||
Member
There was a problem hiding this comment.
Suggested change
| ```html | |
| ```vue |
Member
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

static/code/stackblitz/v9/and the CDN links instatic/usage/v9/toggle/on-off-icons/demo.htmlandstatic/usage/v9/fab/animation/demo.htmlneed to be switched to the released version once 9.1 is out.Issue number: internal
What is the current behavior?
Currently, the toggle docs don't cover changing the on/off label icons, since they were hardcoded per mode.
What is the new behavior?
This PR adds a Custom On / Off Icons section to the toggle docs for the new
checkedIconanduncheckedIconproperties from ionic-team/ionic-framework#31774, and adds thetoggleCheckedIconandtoggleUncheckedIconoptions to the config table. The new playground shows a dark mode toggle with moon and sun icons.Does this introduce a breaking change?
Other information
The dev build is from the framework PR, which already includes the fab
animatedchange, so the fab playground's pin moves to it too.Toggle custom icons docs (this branch)