Skip to content

chore(deps): update @stencil/core to v4.45.4 - #31765

Merged
ShaneK merged 3 commits into
8.8.xfrom
FW-7982-stencil-8.8.x
Nov 17, 2026
Merged

ShaneK merged 3 commits into
8.8.xfrom
FW-7982-stencil-8.8.x

Conversation

@ShaneK

@ShaneK ShaneK commented Nov 17, 2026

Copy link
Copy Markdown
Member

Issue number: internal


What is the current behavior?

Currently, Ionic 8.8 uses @stencil/core 4.43.5. On scoped components like ion-label and ion-buttons, Stencil's patched textContent setter and insertAdjacentText() parse the string as HTML instead of inserting it as text. React sets textContent when an element's only child is a string, so <IonLabel>{name}</IonLabel> renders any markup that ends up in name. This is the v8 backport of #31763.

What is the new behavior?

  • Updates @stencil/core to 4.45.4, which always inserts that text as a text node. components.d.ts picks up the newer generated OneOf type, which matches what main already has.
  • Adds v8-lts to the npm tag options in the release workflow. The only choices were latest and next, so releasing 8.8.20 from this branch would have moved latest off 9.0.x.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Build, spec tests and lint pass locally, and the built dist/esm has the text node fix. Building on this branch also rewrites packages/react/src/components/react-component-lib/utils/index.tsx and drops the cast added in #31223. That happens with or without this bump, so I left the file alone.

@ShaneK
ShaneK requested a review from a team as a code owner November 17, 2026 16:35
@ShaneK
ShaneK requested review from thetaPC and removed request for a team November 17, 2026 16:35
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Nov 17, 2026 4:49pm UTC

Request Review

@ShaneK
ShaneK merged commit 25c7b85 into 8.8.x Nov 17, 2026
49 checks passed
@ShaneK
ShaneK deleted the FW-7982-stencil-8.8.x branch November 17, 2026 16:56
@ShaneK ShaneK mentioned this pull request Nov 17, 2026
1 of 2 tasks

This branch was successfully deployed

1 active deployment
Preview — bc48c299 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant