Repository navigation
chore(deps): update @stencil/core to v4.45.4 - #31763
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
ShaneK
added a commit
that referenced
this pull request
Nov 17, 2026
Issue number: internal
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
Currently, Ionic 8.8 uses `@stencil/core` 4.43.5. On scoped components
like `ion-label` and `ion-buttons`, Stencil's patched `textContent`
setter and `insertAdjacentText()` parse the string as HTML instead of
inserting it as text. React sets `textContent` when an element's only
child is a string, so `<IonLabel>{name}</IonLabel>` renders any markup
that ends up in `name`. This is the v8 backport of #31763.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- Updates `@stencil/core` to
[4.45.4](https://github.com/stenciljs/core/releases/tag/v4.45.4), which
always inserts that text as a text node. `components.d.ts` picks up the
newer generated `OneOf` type, which matches what `main` already has.
- Adds `v8-lts` to the npm tag options in the release workflow. The only
choices were `latest` and `next`, so releasing 8.8.20 from this branch
would have moved `latest` off 9.0.x.
## Does this introduce a breaking change?
- [ ] Yes
- [X] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Build, spec tests and lint pass locally, and the built `dist/esm` has
the text node fix. Building on this branch also rewrites
`packages/react/src/components/react-component-lib/utils/index.tsx` and
drops the cast added in #31223. That happens with or without this bump,
so I left the file alone.
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, Ionic uses
@stencil/core4.45.3. On scoped components likeion-labelandion-buttons, Stencil's patchedtextContentsetter andinsertAdjacentText()parse the string as HTML instead of inserting it as text. React setstextContentwhen an element's only child is a string, so<IonLabel>{name}</IonLabel>renders any markup that ends up inname.What is the new behavior?
Updates
@stencil/coreto 4.45.4, which always inserts that text as a text node, so it renders as the literal string.Does this introduce a breaking change?
Other information