Skip to content

chore(deps): update @stencil/core to v4.45.4 - #31763

Merged
ShaneK merged 1 commit into
mainfrom
FW-7982-stencil
Nov 17, 2026
Merged

ShaneK merged 1 commit into
mainfrom
FW-7982-stencil

Conversation

@ShaneK

@ShaneK ShaneK commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Issue number: internal


What is the current behavior?

Currently, Ionic uses @stencil/core 4.45.3. On scoped components like ion-label and ion-buttons, Stencil's patched textContent setter and insertAdjacentText() parse the string as HTML instead of inserting it as text. React sets textContent when an element's only child is a string, so <IonLabel>{name}</IonLabel> renders any markup that ends up in name.

What is the new behavior?

Updates @stencil/core to 4.45.4, which always inserts that text as a text node, so it renders as the literal string.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ShaneK
ShaneK requested a review from a team as a code owner November 17, 2026 14:47
@ShaneK
ShaneK requested a review from thetaPC November 17, 2026 14:47
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Nov 17, 2026 2:51pm UTC

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Nov 17, 2026
@ShaneK
ShaneK merged commit 240e4f3 into main Nov 17, 2026
57 checks passed
@ShaneK
ShaneK deleted the FW-7982-stencil branch November 17, 2026 15:00
ShaneK added a commit that referenced this pull request Nov 17, 2026
Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Currently, Ionic 8.8 uses `@stencil/core` 4.43.5. On scoped components
like `ion-label` and `ion-buttons`, Stencil's patched `textContent`
setter and `insertAdjacentText()` parse the string as HTML instead of
inserting it as text. React sets `textContent` when an element's only
child is a string, so `<IonLabel>{name}</IonLabel>` renders any markup
that ends up in `name`. This is the v8 backport of #31763.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Updates `@stencil/core` to
[4.45.4](https://github.com/stenciljs/core/releases/tag/v4.45.4), which
always inserts that text as a text node. `components.d.ts` picks up the
newer generated `OneOf` type, which matches what `main` already has.
- Adds `v8-lts` to the npm tag options in the release workflow. The only
choices were `latest` and `next`, so releasing 8.8.20 from this branch
would have moved `latest` off 9.0.x.

## Does this introduce a breaking change?

- [ ] Yes
- [X] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Build, spec tests and lint pass locally, and the built `dist/esm` has
the text node fix. Building on this branch also rewrites
`packages/react/src/components/react-component-lib/utils/index.tsx` and
drops the cast added in #31223. That happens with or without this bump,
so I left the file alone.
@ShaneK ShaneK mentioned this pull request Nov 17, 2026
1 of 2 tasks

This branch was successfully deployed

1 active deployment
Preview — 5328d60f Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant