Repository navigation
chore(deps): update @stencil/core to v4.45.4 - #31765
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, Ionic 8.8 uses
@stencil/core4.43.5. On scoped components likeion-labelandion-buttons, Stencil's patchedtextContentsetter andinsertAdjacentText()parse the string as HTML instead of inserting it as text. React setstextContentwhen an element's only child is a string, so<IonLabel>{name}</IonLabel>renders any markup that ends up inname. This is the v8 backport of #31763.What is the new behavior?
@stencil/coreto 4.45.4, which always inserts that text as a text node.components.d.tspicks up the newer generatedOneOftype, which matches whatmainalready has.v8-ltsto the npm tag options in the release workflow. The only choices werelatestandnext, so releasing 8.8.20 from this branch would have movedlatestoff 9.0.x.Does this introduce a breaking change?
Other information
Build, spec tests and lint pass locally, and the built
dist/esmhas the text node fix. Building on this branch also rewritespackages/react/src/components/react-component-lib/utils/index.tsxand drops the cast added in #31223. That happens with or without this bump, so I left the file alone.