Repository navigation
Added proof-of-concept testing of SocketCAN on Travis CI & Smaller changes - #275
Merged
Merged
Conversation
hardbyte
approved these changes
Mar 16, 2018
hardbyte
left a comment
Owner
There was a problem hiding this comment.
This would be a good pr to squash.
| def __new__(cls, other, filename): | ||
| if filename.endswith(".asc"): | ||
| if not filename: | ||
| TypeError("a filename must be given") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testing can be found in
test/back2back_test.pybut is skipped for now, since it fails on Python 3.3/3.4. See #274. I expanded thetest/config.pyfile to contain information about the platform as well. More serious testing remains to be implemented.I also made small changes to some
can.io.*classes and removed the overall repeated logging (like multiple logging statements for each sent message) quite a bit. I also added some tests tolistener_test.py.