Skip to content

SocketCAN fails on Python versions 3.3 & 3.4 and on PyPy 3 #274

Closed

Description

@felixdivo

This can be found in the Python 3.5 change log and the official docs:

The socket module now exports the CAN_RAW_FD_FRAMES constant on linux 3.6 and greater.

If you look at this CI test, socketcan-native fails for Python versions 3.3 & 3.4 because it uses CAN_RAW_FD_FRAMES on these platforms. How can a interface register itself as not being able to handle CAN FD frames?

There is also another Problem on PyPy 3: module 'socket' has no attribute 'CAN_RAW'.

Activity

  1. changed the title [-]The socket module now exports the CAN_RAW_FD_FRAMES constant on linux 3.6 and greater.[/-] [+]SocketCAN fails on Python versions 3.3 & 3.4 because it uses CAN_RAW_FD_FRAMES[/+] on Feb 28, 2018
  2. felixdivo commented on Mar 2, 2018

    @felixdivo
    CollaboratorAuthor

    Do we even want to support these Python versions any more? At least Python 3.3 has reached its end of life.

  3. felixdivo commented on Mar 2, 2018

    @felixdivo
    CollaboratorAuthor

    See the bottom of test/back2back_test.py on branch more-tests (or maybe develop once it is merged).

  4. changed the title [-]SocketCAN fails on Python versions 3.3 & 3.4 because it uses CAN_RAW_FD_FRAMES[/-] [+]SocketCAN fails on Python versions 3.3 & 3.4 and on PyPy[/+] on Mar 23, 2018
  5. changed the title [-]SocketCAN fails on Python versions 3.3 & 3.4 and on PyPy[/-] [+]SocketCAN fails on Python versions 3.3 & 3.4 and on PyPy 3[/+] on Mar 23, 2018
  6. felixdivo commented on Apr 4, 2018

    @felixdivo
    CollaboratorAuthor

    I propose this change:

    • drop support for Python 3.3, since it reached EOL
    • use socketcan_ctypes on Python 3.4 to be able to use CAN FD frames
    • use socketcan_ctypes on all PyPy versions, since socket.CAN_RAW_* seems to be unavailable there (where are the docs for that?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions