Repository navigation
Link concrete entry classes into usage docs - #5512
Merged
tseaver merged 1 commit intoJun 21, 2018
Merged
Conversation
tswast
reviewed
Jun 20, 2018
tswast
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
In BigQuery we have a similar situation, and we use a Union type rather than referring to the base class. See: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/2252253325826ecf5b769a33d9d70b6427754d1c/bigquery/google/cloud/bigquery/client.py#L606-L609
tswast
approved these changes
Jun 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4118.
Note that those API docs won't be as useful as they could be without either making
_BaseEntrypublic (see #5511) or going to extra effort to propagate the signature docs for__init__.