Skip to content

Consider making '_BaseEntry' public #5511

Closed
Closed
Consider making '_BaseEntry' public#5511
Assignees
tseaver
Labels
api: loggingIssues related to the Cloud Logging API.type: questionRequest for information or clarification. Not an issue.

Description

@tseaver
tseaver
opened on Jun 20, 2018

The autodocs don't do the right thing for the inherited constructors, even when I add in :inherited-members:. Given that we also link the class (e.g., as the item type returned from Client.list_entries / logger.list_entries), we should just make it part of the API.

Activity

  1. tseaver
    added
    type: questionRequest for information or clarification. Not an issue.
    api: loggingIssues related to the Cloud Logging API.
    on Jun 20, 2018
  2. tseaver
    assigned
    tswast
    on Jun 20, 2018
  3. tseaver
    added a commit that references this issue on Jun 21, 2018

    Link concrete entry classes into usage docs. (#5512)

    0503ee7
  4. theacodes
    unassigned
    tswast
    on Sep 28, 2018

  5. tseaver commented on Oct 18, 2018

    @tseaver
    tseaver
    on Oct 18, 2018
    ContributorAuthor

    PR #6229 will make this issue moot: it makes public a LogEntry class, which is used to support payload-less entries: the others (TextEntry, etc.) derive from it.

  6. tseaver
    closed this as completedon Oct 18, 2018
  7. tswast
    assigned
    tseaver
    on Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: loggingIssues related to the Cloud Logging API.type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions