Don't shutdown the ssl executor service too early - #331
Merged
Conversation
Contributor
Author
The ExecutorService held by the DefaultSSLWebSocketServerFactory was being shutdown when the first SSLSocketChannel2 got closed, making it unusable for further connections. It's now being closed on server stop instead.
bendem
force-pushed
the
fix/pool-shutdown
branch
from
August 8, 2015 09:45
67ef6b2 to
d2254b9
Compare
This was referenced Aug 9, 2015
|
This should be added to the main project, it works, fixed the issue for me. |
Contributor
Author
|
at long last 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ExecutorService held by the DefaultSSLWebSocketServerFactory was being shutdown
when the first SSLSocketChannel2 got closed, making it unusable for further connections.
It's now being closed on server stop instead.