do not close executor service when first WebSocket is closed - #216
Closed
sklegg wants to merge 1 commit into
Closed
Conversation
this caused the WebSocket service to die when SSL was used and an ExecutorService was created inside DefaultSSLWebSocketServerFactory
|
i faced this issue aswell yesterday. What about adding the shutdown-method into the interface "WebSocketServerFactory" and let the WebSocketServer shut it down when it gets closed? |
This was referenced Aug 6, 2015
Collaborator
|
fixed by #331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this caused the WebSocket service to die when SSL was used and an
ExecutorService was created inside DefaultSSLWebSocketServerFactory