Repository navigation
dir-sim: licence-state planes through the DT64 lane and selection sockets - #2107
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
💡 Codex Reviewlance-graph/crates/lance-graph-dir-sim/src/dt64.rs Lines 207 to 209 in f037d26 When a caller registers a basis with SMTP before UPN, binding succeeds but field 0 returns UPN and field 1 returns SMTP because this implementation ignores lance-graph/crates/lance-graph-dir-sim/src/license.rs Lines 146 to 149 in f037d26 If an intermediate page is missing but the final page is present, this classifies the collection as ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ept with the planes Gate 0 of D-DIRSIM-LICENSE-DT64-1 (corrections to #2105): code index = (sku, via, state) order with a stable predicate IRI per code; the decoded pages are owned as evidence (paths with assignedByGroup, effective SKUs kept separate); coverage from @odata.nextLink; the planes record their version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on sockets D-DIRSIM-LICENSE-DT64-1 Gates 1-4: LicenseLanes (LaneSource + SelectionSource) in the row order of the version's DirLanes; fields bind codes by predicate IRI; StatePlane is a membership mask, not a value lane; LicenseBasis; Kept::and; typed refusals; 512-user projection with oracle parity and allocation counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… dt64 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f037d26 to
3844bf1
Compare
D-DIRSIM-LICENSE-DT64-1 binds the DR64 licence planes from #2105 through the existing DT64 sockets.
Rebased onto
main(42d8b2a), which now contains #2105 and #2106. The PR is these four commits. It extends #2106'sdt64module, so dir-sim still has a singledt64module.Gate 0: source contract (corrections to #2105, commit
cd0b537)Findings 1 and 3 were confirmed in code and are fixed in
license.rs. Finding 2 was already fixed on #2105's head (69d3b5f,a_repeated_user_is_refused_in_either_order); this PR adds a JSONnullfirst-entry case.(sku, via, state)order. Reordered pages or users give the same code at the same index.reordered_pages_and_users_keep_every_code_in_placepredicate_iriandcode_of.nullfirst entry is still a duplicate.a_null_first_entry_is_still_a_duplicatemissing_empty_and_held_paths_stay_distinctexplain(user, code)returns every path behind a bit, including eachassignedByGroup.holder_countandpath_countstay separate.the_evidence_keeps_both_assigning_groups_behind_one_bitexplainignoring direct vs group → redassignedLicensesis a separate property with its ownEvidence, never derived from the paths.effective_skus_are_not_assignment_paths@odata.nextLink, in any page order. Exactly one page ends the collection =Complete; a link nobody followed =Partial; two ends =Ambiguous.coverage_reads_the_page_links_in_any_orderLicensePlanes::buildnow takes(view, version, Vec<LicensesPage>, Vec<SkuPage>)and owns the evidence instead of borrowing it.Gate 1: the socket (
dt64.rs, featuredt64)LicenseLanes::over(&DirLanes, &LicensePlanes, class, scope)implementsLaneSourceandSelectionSource.DirLanescoordinate space: that version's user ordinals.FrameStore.Complete.lane_ofmapsbasis.predicate_irito a code and never reads the field position.LicenseBasis::of(&planes, class)gives one field per code, in code order. A store binds it once (D5), so a changed codebook cannot be checked against the old class.StatePlaneis a membership mask, not a value lane. A reader usescontains(row)(bit extraction) or handswords()to mask-RISC as a mask. It has no path accessor.Kept::andis a bitmap AND that refuses another relation size. Its result reaches a selection only through the existingselect(&Kept)boundary.Gates 2–4 (
tests/license_dt64.rs, featuredt64)The fixture has:
The oracle comes from the fixture's own rule, never from the planes. User ordinals follow the directory's GUID order, so the oracle maps users through
View::user_ordinal.Gate 2:
Gate 4: typed refusals.
ForeignFrame.Unbound. It is never read at the slot that now holds another code; a surviving code resolves to its new index.Bind(_).OtherVersion.Scope.CoordinateSpace.FieldNotInBasis.assignedLicensesfield:Unbound.Incomplete(Partial).ExplainRefusal::NotRead.Disable runs:
Gate 3, measured. One run, release build, this container's VM; not certified on a dedicated host.
Locality questions (
dr-dt64-locality-execution-contract.md)predicate_iri, coordinate space (population and version), scope, and the planes' version and coverage.Consumer handoff (report-rs, later)
Admission limits:
Scopeis a consistency check, not authorization. IAM decides separately (contract boundary 5); nothing here grants a field.Open
Keptcarries its relation's size, not its version. The caller vouches that both results are over the same version, and DT64 checks the coordinate space on read.capacity_coverage()exists for the SKU capacity pages, but nothing refuses on it yet.Checks after the rebase:
dt64: 306 passed, 0 failed.-D warningswithdt64: clean.rbac.identity.ymlrunslicense_dt64withdt64.D-DIRSIM-LICENSE-DT64-1.🤖 Generated with Claude Code
https://claude.ai/code/session_01XAqKMQJzQD5KvNm8BtbsWG