Skip to content

dir-sim: results through the DT64 lane socket at DR64 / DR256 / n x DR256 - #2106

Merged
AdaWorldAPI merged 2 commits into
mainfrom
ccr-85acaff0-oszq40-dirsim-dt64-lanes
Nov 16, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
ccr-85acaff0-oszq40-dirsim-dt64-lanes

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

dir-sim results that already work (subtree, users_with_key, …) can now be bound through the DT64 lane socket. New module lance-graph-dir-sim::dt64 (feature dt64): DirLanes implements LaneSource + SelectionSource over one version's View.

  • DR axis from the survivors. DirLanes::select(&Kept) takes Axis::for_survivors(kept.len()): ≤ 64 rows one DR64 tile, ≤ 256 one DR256 tile, more ⌈n/256⌉ DR256 tiles. The count is a popcount (Kept::len, new); no row is decoded to choose the axis.
  • Virtual tuples, no early materialization. A UserLane holds no column. lane.get(i) reads the user at ordinal i through the version's View, so base values, overridden values and users the version created read correctly, with nothing copied. A[i]:B[i] is two reads at one known i.
  • One version, one frame store. A binding made over another version's DirLanes is refused with ForeignFrame before any lane is borrowed.
  • Wrong population refused. A result over groups (or another version's users) is SelectRefusal::NotUsers.
  • New Kept::len / is_empty / universe in exec.rs; CI step in identity.yml runs the tests with --features dt64.

Locality questions (dr-dt64-locality-execution-contract.md)

  1. Once per binding / per operation. The selection's position list is built once per select, bounded by its survivors; the binding is made once; each cell read is a View lookup at a known row.
  2. Witnesses. Class, schema rev, field, coordinate space (population = class, coordinates = version), scope, frame store instance.
  3. Copies. The position list (Vec<u32>, survivors only), because SelectionSource::borrow_positions returns &[u32] and Kept is a bitmap. No value is copied.
  4. Measured. The read path allocates 0 times (counting allocator, all six widths). Scope remains a consistency check, not authorization.

Tests (tests/dt64_lanes.rs)

  • every width (40, 64, 65, 200, 512, 1000 survivors): expected axis, and every selected UPN/SMTP cell equals View::attr, 0 allocations;
  • a re-observed version reads its override and a created user; the old binding is refused (ForeignFrame);
  • a groups result is refused (NotUsers { rows: 3, users: 5 }), a users result is admitted.

Disable runs on the committed tree: fixed axis, population axis, row ignored, NotUsers check removed: all red. A frame-revision disable stayed green: the refusal comes from the frame-store instance, not its revision, so that disable did not reach the guard. Not counted as evidence.

Gates: fmt; clippy -D warnings without features, with dt64, with rbac; dir-sim suite 284 passed (287 with dt64), 0 failed.

Open


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ce424c63-7bb4-43cb-952c-38ad1ea96c96
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review November 16, 2026 14:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T14:16:41.916993Z 8bb31cf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 10b9dc0 into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants