Repository navigation
dir-sim: results through the DT64 lane socket at DR64 / DR256 / n x DR256 - #2106
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
November 16, 2026 14:15
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dir-sim results that already work (
subtree,users_with_key, …) can now be bound through the DT64 lane socket. New modulelance-graph-dir-sim::dt64(featuredt64):DirLanesimplementsLaneSource+SelectionSourceover one version'sView.DirLanes::select(&Kept)takesAxis::for_survivors(kept.len()): ≤ 64 rows one DR64 tile, ≤ 256 one DR256 tile, more ⌈n/256⌉ DR256 tiles. The count is a popcount (Kept::len, new); no row is decoded to choose the axis.UserLaneholds no column.lane.get(i)reads the user at ordinalithrough the version'sView, so base values, overridden values and users the version created read correctly, with nothing copied.A[i]:B[i]is two reads at one knowni.DirLanesis refused withForeignFramebefore any lane is borrowed.SelectRefusal::NotUsers.Kept::len/is_empty/universeinexec.rs; CI step inidentity.ymlruns the tests with--features dt64.Locality questions (
dr-dt64-locality-execution-contract.md)select, bounded by its survivors; the binding is made once; each cell read is aViewlookup at a known row.population = class,coordinates = version), scope, frame store instance.Vec<u32>, survivors only), becauseSelectionSource::borrow_positionsreturns&[u32]andKeptis a bitmap. No value is copied.Scoperemains a consistency check, not authorization.Tests (
tests/dt64_lanes.rs)View::attr, 0 allocations;ForeignFrame);NotUsers { rows: 3, users: 5 }), a users result is admitted.Disable runs on the committed tree: fixed axis, population axis, row ignored,
NotUserscheck removed: all red. A frame-revision disable stayed green: the refusal comes from the frame-store instance, not its revision, so that disable did not reach the guard. Not counted as evidence.Gates: fmt; clippy
-D warningswithout features, withdt64, withrbac; dir-sim suite 284 passed (287 withdt64), 0 failed.Open
UserLane::getreturnsNonefor them (same asView).Generated by Claude Code