Repository navigation
Test cleanup - #60
Merged
Merged
Test cleanup#60
Conversation
These probably got added by default from a IDE but are unnecessary noise (in my opinion).
Depending on your font it can be confusing with lowercase l instead of uppercase. Not very important but a quick stylistic change while I'm here.
One of my "pet peeves" an easily made mistake when switching between projects that use junit or hamcrest or AssertJ, etc. When submitting my other PR I noticed that some tests used the correct ordering and some used the correct ordering. This commit makes the usage consistent.
Collaborator
|
Nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of my "pet peeves", incorrect ordering of arguments to assertion libraries, it's an easily made mistake when switching between projects that use junit or hamcrest or AssertJ, etc. When submitting
my other PR I noticed that some tests used the correct ordering and some
used the correct ordering so I thought that while it is Hacktober I may as well make another contribution.
If you would prefer a refactor to Hamcrest/AssertJ style assertions I could look into that too but it didn't seem worth it for such a small library.
Added a couple of very small stylistic commits in the same PR.