Skip to content

Test cleanup - #60

Merged
0x3333 merged 3 commits into
yomorun:masterfrom
sharebear:test_cleanup
Oct 5, 2018
Merged

0x3333 merged 3 commits into
yomorun:masterfrom
sharebear:test_cleanup

Conversation

@sharebear

Copy link
Copy Markdown
Contributor

One of my "pet peeves", incorrect ordering of arguments to assertion libraries, it's an easily made mistake when switching between projects that use junit or hamcrest or AssertJ, etc. When submitting
my other PR I noticed that some tests used the correct ordering and some
used the correct ordering so I thought that while it is Hacktober I may as well make another contribution.

If you would prefer a refactor to Hamcrest/AssertJ style assertions I could look into that too but it didn't seem worth it for such a small library.

Added a couple of very small stylistic commits in the same PR.

These probably got added by default from a IDE but are unnecessary noise
(in my opinion).
Depending on your font it can be confusing with lowercase l instead of
uppercase. Not very important but a quick stylistic change while I'm here.
One of my "pet peeves" an easily made mistake when switching between
projects that use junit or hamcrest or AssertJ, etc. When submitting
my other PR I noticed that some tests used the correct ordering and some
used the correct ordering. This commit makes the usage consistent.
@0x3333

0x3333 commented Oct 5, 2018

Copy link
Copy Markdown
Collaborator

Nice catch.

@0x3333
0x3333 merged commit 162a263 into yomorun:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants