Skip to content

Various setup improvements - #4

Open
gemmaro wants to merge 6 commits into
tlewin:masterfrom
gemmaro:re/setup
Open

gemmaro wants to merge 6 commits into
tlewin:masterfrom
gemmaro:re/setup

Conversation

@gemmaro

@gemmaro gemmaro commented Oct 29, 2026

Copy link
Copy Markdown

Hello, this is various minor setup improvements, including:

  • Utilizing rake-compiler's compile task ...(a)
  • More standard way to require Ruby modules (using require_relative and unshifting to $LOAD_PATH)
  • Use the standard stdbool.h header for boolean type and values
  • Prevent loading error of the uri gem by explicitly requiring in advance
Additional note about (a)

The custom ext:build task seems to cause a race issue between clobber and compile in some case like invoking rake compile test:

[...]
linking shared-object uriparser_ext.so
cd -
(cd tmp/x86_64-openbsd/uriparser_ext/4.0.9 && /usr/local/bin/gmake install sitearchdir=../../../../lib sitelibdir=../../../../lib target_prefix=)
/usr/bin/install -c -m 0755 uriparser_ext.so ../../../../lib
cp tmp/x86_64-openbsd/uriparser_ext/4.0.9/uriparser_ext.so tmp/x86_64-openbsd/stage/lib/uriparser_ext.so
/usr/local/bin/ruby40 -w -I"lib:test" /home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/lib/rake/rake_test_loader.rb "test/uriparser_test.rb" -v
/home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/shoulda-context-1.2.2/lib/shoulda/context/context.rb:400: warning: assigned but unused variable - context
/home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/shoulda-matchers-3.1.3/lib/shoulda/matchers/active_model/allow_value_matcher/attribute_setter.rb:229: warning: method redefined; discarding old model
/home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/shoulda-matchers-3.1.3/lib/shoulda/matchers/active_model/allow_value_matcher/attribute_setter.rb:149: warning: previous definition of model was here
/home/gemmaro/src/_vendor/ruby-uriparser/lib/uriparser.rb:4:in 'Kernel#require_relative': cannot load such file -- /home/gemmaro/src/_vendor/ruby-uriparser/lib/uriparser_ext (LoadError)
	from /home/gemmaro/src/_vendor/ruby-uriparser/lib/uriparser.rb:4:in '<top (required)>'
	from /home/gemmaro/src/_vendor/ruby-uriparser/test/test_helper.rb:8:in 'Kernel#require'
	from /home/gemmaro/src/_vendor/ruby-uriparser/test/test_helper.rb:8:in '<top (required)>'
	from /home/gemmaro/src/_vendor/ruby-uriparser/test/uriparser_test.rb:3:in 'Kernel#require'
	from /home/gemmaro/src/_vendor/ruby-uriparser/test/uriparser_test.rb:3:in '<top (required)>'
	from /home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/lib/rake/rake_test_loader.rb:21:in 'Kernel#require'
	from /home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/lib/rake/rake_test_loader.rb:21:in 'block in <main>'
	from /home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/lib/rake/rake_test_loader.rb:6:in 'Array#select'
	from /home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/lib/rake/rake_test_loader.rb:6:in '<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" /home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/lib/rake/rake_test_loader.rb "test/uriparser_test.rb" -v]
/home/gemmaro/src/_vendor/ruby-uriparser/.direnv/ruby/gems/rake-13.4.2/exe/rake:27:in '<top (required)>'
Tasks: TOP => test
(See full trace by running task with --trace)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant