Repository navigation
Added withLogConsumer() method to DockerComposeContainer - #629
Merged
bsideup merged 3 commits intoApr 7, 2018
Merged
Conversation
bsideup
reviewed
Apr 4, 2018
| .withExposedService("redis_1", 6379) | ||
| .withLogConsumer("redis_1", logConsumer); | ||
|
|
||
| environment.starting(Description.createTestDescription(Object.class, "name")); |
Member
There was a problem hiding this comment.
- please add
try {} finally { }, otherwise this redis image will remain until the JVM exits - use Description.EMPTY
# Conflicts: # CHANGELOG.md
bsideup
approved these changes
Apr 6, 2018
kiview
approved these changes
Apr 6, 2018
kiview
left a comment
Member
There was a problem hiding this comment.
LGTM, I'd check this change on Docker for Windows on the weekend, there are sometimes some quirks involved on Docker-Compose on Windows, but I see no reason why it should not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
withLogConsumer(String serviceName, Consumer<OutputFrame> consumer)method toDockerComposeContainerFixes #605