Skip to content

#371 'posix fallback bug' - added fallback in case of UnsupportedOperationException - #376

Merged
bsideup merged 2 commits into
testcontainers:masterfrom
glebsts:posix-fallback-fix
Jun 20, 2017
Merged

bsideup merged 2 commits into
testcontainers:masterfrom
glebsts:posix-fallback-fix

Conversation

@glebsts

@glebsts glebsts commented Jun 20, 2017 •

Copy link
Copy Markdown
Contributor

Added additional exception type to fallback catch clause, as Windows env throws UnsupportedOperationException when trying to get not-existing file attribute

@bsideup bsideup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a small mention of it in CHANGELOG.md? Thanks!

@glebsts

glebsts commented Jun 20, 2017

Copy link
Copy Markdown
Contributor Author

updated changelog

@bsideup bsideup added this to the 1.3.1 milestone Jun 20, 2017
@bsideup
bsideup merged commit 82485c9 into testcontainers:master Jun 20, 2017
@bsideup

bsideup commented Jun 20, 2017

Copy link
Copy Markdown
Member

@glebsts Thanks! 👍

@glebsts
glebsts deleted the posix-fallback-fix branch June 24, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants