Skip to content

#1802: added JdbcDatabaseContainer#withUrlParam - #1962

Closed
witjem wants to merge 10 commits into
testcontainers:masterfrom
witjem:1802-add-JdbcDatabaseContainer#withUrlParam
Closed

witjem wants to merge 10 commits into
testcontainers:masterfrom
witjem:1802-add-JdbcDatabaseContainer#withUrlParam

Conversation

@witjem

@witjem witjem commented Oct 8, 2019 •

Copy link
Copy Markdown

Added JdbcDatabaseContainer#withUrlParam
Added support JdbcDatabaseContainer#getJdbcUrl with url params for:

  • CockroachContainer
  • Db2Container
  • MariaDBContainer
  • MSSQLServerContainer
  • MySQLContainer
  • PostgreSQLContainer

For OracleContainer and ClickHouseContainer not implemented because not found in the documentation how to set URL params for this databases

@witjem
witjem marked this pull request as ready for review October 9, 2019 13:53

@rnorth rnorth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm afraid I think this is a duplicate of #1874 (which started out as just being for MySQL but extended to other container types).

Or does this do something different?

@witjem

witjem commented Oct 18, 2019

Copy link
Copy Markdown
Author

@rnorth Yes, you are right, I didn't pay attention to #1874

@witjem witjem closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants