Skip to content

Master testcontainers-java breaks ReadonlyREST #493

Closed

Description

@sscarduzio

Hello guys!
I've been purposely running with:

    compile 'com.github.testcontainers.testcontainers-java:testcontainers:master-SNAPSHOT'

on my gradle settings for a while. And all went without problems, until recently, when I got this failed build on travis-ci.

https://travis-ci.org/sscarduzio/elasticsearch-readonlyrest-plugin/jobs/302127237

Everything worked again after reverting to the latest stable 1.4.3.

Any ideas?

Activity

  1. bsideup commented on Nov 14, 2017

    @bsideup
    Member

    @sscarduzio
    From the logs:

    Could not build image: The command '/bin/sh -c sed -i "s|debug|info|g" /usr/share/elasticsearch/config/log4j2.properties' returned a non-zero code: 2

    Such error might be a flaky test or something caused by 2ad57da

    May I kindly ask you to try first this one:
    com.github.testcontainers.testcontainers-java:testcontainers:2ad57da4a4f7b0d3396c4883294aa9c32ef480e7

    And then:
    com.github.testcontainers.testcontainers-java:testcontainers:1c66a143e6513d25b4d60044303b2fabf1c6c0fb

    Thanks for letting us know before it got released! :)

  2. sscarduzio commented on Nov 14, 2017

    @sscarduzio
    ContributorAuthor

    Hi @bsideup,
    Just ran this on my laptop. You are right:

    2ad57da <--- test runs
    1c66a14 <--- test fails as above

  3. added 3 commits that reference this issue on Nov 26, 2017
    643ddaa
    263ac20
    1391d8c
  4. rnorth commented on Nov 26, 2017

    @rnorth
    Member

    Thanks for flagging this @sscarduzio - this should be fixed in the latest master. Thanks to your report we'll avoid shipping this bug in a released version 😅 !

  5. sscarduzio commented on Nov 27, 2017

    @sscarduzio
    ContributorAuthor

    Thanks @rnorth for fixing this, I can confirm now it works because I reverted the dependency to the master branch of testcontainers-java. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions