Skip to content

Strong coupling with "alpine:3.2" image in DockerClientFactory #281

Closed

Description

@dddpaul

Hello.

When #267 was merged running docker inside docker works fine :) This feature is very useful for CI pipelines when Jenkins slave executes in Docker container, for example.

But build servers may have partial Internet connectivity - to the local Docker registry only (just like in my case). So despite of wonderful docker-in-docker support build fails nevertheless on DockerClientFactory.instance().client() invoke.

Can we get rid of this builtin image dependency or make it customizable at least? For example, pass image name to DockerClientFactory through environment variable?

Activity

  1. bsideup commented on Jan 24, 2017

    @bsideup
    Member

    Hi @dddpaul,

    I suppose #277 will help; we just have to make TINY_IMAGE configurable.

    Will it work for you? (properties file configuration of the images)

  2. rnorth commented on Jan 24, 2017

    @rnorth
    Member

    Yes, sorry - I should have remembered to include this in #277

  3. dddpaul commented on Jan 24, 2017

    @dddpaul
    Author

    @bsideup Yes it's will be perfect.

  4. dddpaul commented on Jan 31, 2017

    @dddpaul
    Author

    @bsideup @rnorth Can I help with this issue? I can try to make #277-like PR by myself.

  5. bsideup commented on Jan 31, 2017

    @bsideup
    Member

    @dddpaul Sure! Fine by me, we're always welcome any contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions