Add support for $HOME/.docker/config.json #247

Activity

1. rnorth commented on Dec 12, 2016

   

   rnorth

   on Dec 12, 2016 via email

   Member

   More actions

   Hi Aboubacar That seems sensible, thanks for suggesting. If you or anybody else would like to raise a PR it would be most welcome! Would it perhaps make sense to check for the existence of the config.json file and use that first, falling back to dockercfg otherwise? I'd like Testcontainers to select a sensible default rather than the user having to inform the tool which file to look at. Thanks Richard

   …

   On Fri, 2 Dec 2016 at 19:08 Aboubacar Toure ***@***.***> wrote: The current version (1.1.7) hardcodes the private registry authentication file to use ($HOME/.docker/.dockercfg). It would be nice to add support for $HOME/.docker/config.json. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#247>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIET7Lxx2s06-7U0ZllmcsTxsy4eefFks5rEGyQgaJpZM4LC4jK> .
2. tourea

   added a commit that references this issue on Jan 18, 2017

   Issue 247: Add support for $HOME/.docker/config.json

   ...

   26b3eb2
3. tourea commented on Jan 18, 2017

   

   tourea

   on Jan 18, 2017

   ContributorAuthor

   More actions

   @rnorth I've opened a PR to resolve this issue (#270)
4. rnorth

   modified the milestone: 1.1.8 on Jan 22, 2017
5. rnorth

   closed this as completedon Jan 22, 2017