Skip to content

Extract duplicated snapshot-cap literal in ExceptionProbeManager #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jaipilot wants to merge 1 commit into
base: jaipilot-campaign/dd-trace-java-12254-head
Choose a base branch
from
Draft

Extract duplicated snapshot-cap literal in ExceptionProbeManager #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...nt/agent-debugger/src/main/java/com/datadog/debugger/exception/ExceptionProbeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ boolean hasExceptionStateTracked() {
}

public static class ThrowableState {
private static final int MAX_SNAPSHOTS = 256;

private final String exceptionId;
private final List<Snapshot> snapshots = new ArrayList<>();
private boolean snapshotSent;
Expand All @@ -202,8 +204,11 @@ public List<Snapshot> getSnapshots() {
}

public void addSnapshot(Snapshot snapshot) {
if (snapshots.size() > 256) {
LOGGER.debug("Too many (256) snapshots for exceptionId={}, dropping snapshot", exceptionId);
if (snapshots.size() > MAX_SNAPSHOTS) {
LOGGER.debug(
"Too many ({}) snapshots for exceptionId={}, dropping snapshot",
MAX_SNAPSHOTS,
exceptionId);
return;
}
snapshots.add(snapshot);
Expand Down