JAIPilot campaign evaluation: DataDog/dd-trace-java #12254 - #1
Open
skrcode wants to merge 2 commits into
Open
Conversation
HotSpot JVM has a special optimization when some special exceptions are (implicitly) thrown like NullPointerException. The JIT will replace a throw with a newly created Exception that walk the stack to produce the stacktrace by a throw with a singleton instance of the exception without stacktrace. This singleton exception is kept forever by the JVm contrary to usual way to throw exception to create the object at location of the exception. Therefore the map snapshotsByThrowable in ExceptionProbeManager which maps Exception instance to ThrowableState object keep an instance forever with the along snapshots collected. At some point the number of snapshots kept can lead to OOME. The fix is to clear the snapshot list after sending the snapshot and tagging the span. We also add a cap to the number of snapshots (256) added to the ThrowableState object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact cloud-only evaluation mirror of DataDog#12254
Exact upstream head: a882216
JAIPilot must return at most one small, behavior-preserving, independently provable companion draft or leave this PR unchanged. No repository build is being run on a developer laptop.