Repository navigation
Rearrange SPEC sections - #256
Merged
jarrodmillman merged 8 commits intoAug 3, 2023
Merged
Conversation
jarrodmillman
force-pushed
the
rearrange-spec-sections
branch
from
August 2, 2023 18:25
6e0d22c to
e0c9192
Compare
Member
Author
|
pre-commit.ci autofix |
stefanv
reviewed
Aug 2, 2023
stefanv
left a comment
Member
There was a problem hiding this comment.
This is a review of the SPEC 1 refactoring. Some minor comments, but 👍 overall. Thanks!
stefanv
approved these changes
Aug 2, 2023
As discussed in the last steering committee meeting. See scientific-python#247.
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
jarrodmillman
force-pushed
the
rearrange-spec-sections
branch
from
August 2, 2023 22:37
27a9ce0 to
abe3737
Compare
Member
Author
|
pre-commit.ci autofix |
tupui
approved these changes
Aug 3, 2023
tupui
left a comment
Member
There was a problem hiding this comment.
Thanks! I like this new structure, I think it brings clarity and looking at SPEC1, I think it's now easier to parse and understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the last steering committee meeting. See #247.