Modified logic yo use == instead of is to make sure we dont encounter…#160
Merged
rsokl merged 1 commit intoAug 14, 2020
Conversation
rsokl
approved these changes
Aug 14, 2020
rsokl
left a comment
Owner
There was a problem hiding this comment.
Looks good! This will be in the next release of PLYMI :)
Owner
|
closes #159 |
Contributor
Author
|
Thanks Ryan. This is my First Open Source PR and I am very excited.
Thanks for the opportunity. I have some new content ideas and reach you out
soon. Is there any specific email ID that I can use to be in touch with you?
Ravi Chandra Veeramachaneni
…On Fri, Aug 14, 2020 at 2:42 PM Ryan Soklaski ***@***.***> wrote:
closes #159 <#159>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ7G7JWNJUYVKNXXAADCKLSAWVURANCNFSM4P7ZR5EQ>
.
|
Owner
|
@ravichandraveeramachaneni it would be best for you to post those ideas in the issue thread on this GitHub repo. This way the other PLYMI contributors/developers can participate in the discussions about ideas / new content. Best regards, |
Contributor
Author
|
Thanks Ryan. Will do that. Have some ideas and will do that soon.
Thanks in Advance
Regards,
Ravi Chandra Veeramachaneni
… On Aug 19, 2020, at 8:10 PM, Ryan Soklaski ***@***.***> wrote:
@ravichandraveeramachaneni it would be best for you to post those ideas in the issue thread on this GitHub repo. This way the other PLYMI contributors/developers can participate in the discussions about ideas / new content.
Best regards,
Ryan
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… warnings