Skip to content

Remove SceneTracker module and its use in AppRegistry (#57417) #57417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubennorte wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −77
Open

Remove SceneTracker module and its use in AppRegistry (#57417) #57417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/Libraries/ReactNative/AppRegistry.flow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ export type Registry = {
};
export type WrapperComponentProvider = (
appParameters: Object,
appKey?: string,
) => React.ComponentType<any>;
export type RootViewStyleProvider = (appParameters: Object) => ViewStyleProp;
5 changes: 2 additions & 3 deletions packages/react-native/Libraries/ReactNative/AppRegistryImpl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import type {
WrapperComponentProvider,
} from './AppRegistry.flow';

import SceneTracker from '../Utilities/SceneTracker';
import DeprecatedPerformanceLoggerStub from './DeprecatedPerformanceLoggerStub';
import {coerceDisplayMode} from './DisplayMode';
import HeadlessJsTaskError from './HeadlessJsTaskError';
Expand Down Expand Up @@ -105,7 +104,8 @@ export function registerComponent(
initialProps: appParameters.initialProps,
rootTag: appParameters.rootTag,
WrapperComponent:
wrapperComponentProvider && wrapperComponentProvider(appParameters),
wrapperComponentProvider &&
wrapperComponentProvider(appParameters, appKey),
rootViewStyle:
rootViewStyleProvider && rootViewStyleProvider(appParameters),
isLogBox: appKey === 'LogBox',
Expand Down Expand Up @@ -212,7 +212,6 @@ export function runApplication(
"* A module failed to load due to an error and `AppRegistry.registerComponent` wasn't called.",
);

SceneTracker.setActiveScene({name: appKey});
runnables[appKey](appParameters, coerceDisplayMode(displayMode));
}

Expand Down
42 changes: 0 additions & 42 deletions packages/react-native/Libraries/Utilities/SceneTracker.js
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions packages/react-native/Libraries/Utilities/__tests__/SceneTracker-itest.js
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions packages/react-native/ReactNativeApi.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<67eb674c33870c82986054f0cee48385>>
* @generated SignedSource<<7182d8669bdc02b7ac879b3f178bb1c1>>
*
* This file was generated by scripts/js-api/build-types/index.js.
*/
Expand Down Expand Up @@ -5883,6 +5883,7 @@ declare function Wrapper_default(
): React.ReactNode
declare type WrapperComponentProvider = (
appParameters: Object,
appKey?: string,
) => React.ComponentType<any>
export {
AccessibilityActionEvent, // a0d4daa0
Expand All @@ -5905,7 +5906,7 @@ export {
AndroidKeyboardEvent, // e03becc8
Animated, // 91a7b171
AppConfig, // 35c0ca70
AppRegistry, // 7ef8e53a
AppRegistry, // 1e8c5a00
AppState, // 12012be5
AppStateEvent, // 80f034c3
AppStateStatus, // 447e5ef2
Expand Down Expand Up @@ -6184,7 +6185,7 @@ export {
VirtualizedSectionList, // 9fd9cd61
VirtualizedSectionListInstance, // 12b706d5
VirtualizedSectionListProps, // 12a58a4f
WrapperComponentProvider, // 4b8c7962
WrapperComponentProvider, // 9ef54e61
codegenNativeCommands, // 628a7c0a
codegenNativeComponent, // 32a1bca6
findNodeHandle, // 93f80214
Expand Down
2 changes: 1 addition & 1 deletion packages/virtualized-lists/Lists/FillRateHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ let _sampleRate = DEBUG ? 1 : null;
* samples (e.g. to log them), make sure to call `FillRateHelper.setSampleRate(0.0-1.0)`.
*
* Listeners and sample rate are global for all `VirtualizedList`s - typical usage will combine with
* `SceneTracker.getActiveScene` to determine the context of the events.
* the active scene/route to determine the context of the events.
*/
class FillRateHelper {
_anyBlankStartTime: ?number = null;
Expand Down
Loading