Make flaky RNTester image E2E flows Android-only#57405
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
Summary: The `image-blur-prefetch` and `image-wide-gamut` Maestro flows under `packages/rn-tester/.maestro/` were added recently and are too flaky on the iOS E2E job (`test_e2e_ios_rntester`), repeatedly failing builds in the React Native OSS repo. Both rely on `assertScreenshot` color/blur comparisons that don't reproduce reliably on the iOS simulator in CI. This wraps each flow in a `runFlow: when: platform: Android` guard and adds the `android-only` tag, matching the existing pattern used by `image-progressive-jpeg.yml` and `image-getsize-local-drawables.yml`. On iOS the wrapped `runFlow` is skipped, leaving an empty (passing) flow; on Android the flow runs in full, so Android coverage is unchanged. The long-standing `image.yml` flow (cross-platform test case in place since 2024) is intentionally left untouched and continues to run on iOS. Changelog: [Internal] Differential Revision: D110372082
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110372082. |
|
This pull request has been merged in dfab628. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
image-blur-prefetchandimage-wide-gamutMaestro flows underpackages/rn-tester/.maestro/were added recently and are too flaky on the iOS E2E job (test_e2e_ios_rntester), repeatedly failing builds in the React Native OSS repo. Both rely onassertScreenshotcolor/blur comparisons that don't reproduce reliably on the iOS simulator in CI.This wraps each flow in a
runFlow: when: platform: Androidguard and adds theandroid-onlytag, matching the existing pattern used byimage-progressive-jpeg.ymlandimage-getsize-local-drawables.yml. On iOS the wrappedrunFlowis skipped, leaving an empty (passing) flow; on Android the flow runs in full, so Android coverage is unchanged.The long-standing
image.ymlflow (cross-platform test case in place since 2024) is intentionally left untouched and continues to run on iOS.Changelog: [Internal]
Differential Revision: D110372082