Skip to content

Support channel broadcasting in Cortex-M explicit layout - #24761

Draft
rascani wants to merge 1 commit into
gh/rascani/52/headfrom
gh/rascani/53/head
Draft

rascani wants to merge 1 commit into
gh/rascani/52/headfrom
gh/rascani/53/head

Conversation

@rascani

@rascani rascani commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Channel-broadcast add, mul, and sub on contiguous NCHW inputs currently
fall back to float in explicit layout. Recognize these patterns and use
the existing layout pass to place their channels in the innermost
dimension. Preserve that layout during copy removal and let the existing
add and mul kernels consume channel vectors in either supported layout.

Cover both operand orders, singleton dimensions, chained broadcasts,
convolution producers, and unsupported spatial broadcasts. MobileNetV3
now retains all 28 quantized multiplies with one input/output
quantization boundary. All 165 host tests and 25 M55 simulator cases
passed; eight existing cases remain expected failures. Targeted lint
also passed.

Authored with AI using Codex.

[ghstack-poisoned]
@rascani

rascani commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

@pytorch-bot

pytorch-bot Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24761

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7977a82 with merge base 472953c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2026

This branch was previously deployed

1 inactive deployment
cadence — 7977a82c Deployed Nov 7, 2026 by rascani via hifi-op-test / hifi4 #37193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant