Skip to content

Arm VGF backend: export the runtime core dependency for its headers - #24751

Open
digantdesai wants to merge 1 commit into
pytorch:mainfrom
digantdesai:export-D130285717
Open

digantdesai wants to merge 1 commit into
pytorch:mainfrom
digantdesai:export-D130285717

Conversation

@digantdesai

@digantdesai digantdesai commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary: VGFBoundaryIO.h, an exported header of vgf_backend, includes executorch/runtime/core/error.h, but vgf_backend only had //executorch/runtime/core:core in deps. Targets that include the header, such as vgf_zero_copy_test, could not find error.h. Move the dependency to exported_deps so it reaches them. Buck only; the CMake build already links it.

Differential Revision: D130285717

cc @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Summary: `VGFBoundaryIO.h`, an exported header of `vgf_backend`, includes `executorch/runtime/core/error.h`, but `vgf_backend` only had `//executorch/runtime/core:core` in `deps`. Targets that include the header, such as `vgf_zero_copy_test`, could not find `error.h`. Move the dependency to `exported_deps` so it reaches them. Buck only; the CMake build already links it.

Differential Revision: D130285717
@digantdesai
digantdesai requested a review from rascani as a code owner November 6, 2026 21:32
Copilot AI balanced review requested due to automatic review settings November 6, 2026 21:32
@pytorch-bot

pytorch-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24751

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a552770 with merge base 62ce0bb (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@meta-codesync

meta-codesync Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D130285717.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants