Repository navigation
Arm VGF backend: export the runtime core dependency for its headers - #24751
digantdesai wants to merge 1 commit into
Conversation
Summary: `VGFBoundaryIO.h`, an exported header of `vgf_backend`, includes `executorch/runtime/core/error.h`, but `vgf_backend` only had `//executorch/runtime/core:core` in `deps`. Targets that include the header, such as `vgf_zero_copy_test`, could not find `error.h`. Move the dependency to `exported_deps` so it reaches them. Buck only; the CMake build already links it. Differential Revision: D130285717
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24751
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a552770 with merge base 62ce0bb ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D130285717. |
This PR needs a
|
rascani
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary:
VGFBoundaryIO.h, an exported header ofvgf_backend, includesexecutorch/runtime/core/error.h, butvgf_backendonly had//executorch/runtime/core:coreindeps. Targets that include the header, such asvgf_zero_copy_test, could not finderror.h. Move the dependency toexported_depsso it reaches them. Buck only; the CMake build already links it.Differential Revision: D130285717
cc @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani