Fix syntax error in .mention-bot#361
Merged
Merged
Conversation
alex
approved these changes
Mar 1, 2017
Member
|
I am only slightly a moron. Thanks @berkerpeksag! |
dstufft
approved these changes
Mar 1, 2017
Member
Author
|
I don't know why, but https://travis-ci.org/python/cpython/requests marked this as "Job rejected". It's 4 am here so I will take a look at Travis later today :) |
Member
|
@berkerpeksag that's jsut for the branch itself. When you create a branch in the python/cpython repo it sends a webhook to Travis to have Travis run tests, then when you send a PR it does it again. To reduce he need to run the tests twice, we have travis configured to reject test runs for any branches except |
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
SonicField
added a commit
to SonicField/cpython
that referenced
this pull request
May 12, 2026
…first Implements queue item 9 per supervisor 18:04:09Z disposition of pythia python#361 substantive (3) — replaces description-only feedback_compile_before_commit (D-1776482908, 2026-04-22) enforcement with actual git pre-commit hook that BLOCKS commits on build failure. Closes the 13-day enforcement gap that produced today's c4 three-amend cycle (2026-05-12 14:14Z linker fail, 15:33Z compile fail, 15:53Z PASS). Per pythia python#361 + supervisor 16:49:09Z: 'enforcement-gap-detection-as-yet -another-rule' superseded by structural git hook that runs the build. Behaviour: - Runs scripts/build_phoenix.sh (incremental build, no --clean by default; catches the c4 failure class at ~1-2min budget vs 5-10min for clean) - Exit 0 -> commit proceeds; non-0 -> commit BLOCKED with log path + last 40 lines of build output + actionable hint - Skip path-pattern: docs/*, *.md, docs/benchmarks/*, docs/gates/* — pure doc/data commits don't run the build - Opt-out via PHOENIX_SKIP_BUILD_CHECK=1 (USE WITH CARE; trailer in commit msg per reviewer-audit pattern) - Self-contained: if scripts/build_phoenix.sh isn't found, hook exits 0 (do not block); if not in a git repo, hook exits 0 (do not block) Install (one-time, per-clone): ln -s ../../scripts/pre-commit-build-check.sh .git/hooks/pre-commit Why incremental, not --clean: - Pre-commit budget ~1-2min (clean is 5-10min, would discourage hook use) - Incremental catches the c4 class (linker undef-symbol, compile errors in .h inline definitions, missing decl visibility) - --clean still recommended after JIT header layout changes per CLAUDE.md 'JIT Header Change Protocol' — hook does NOT replace that protocol, only catches the more common 'I forgot to compile' class Single doc/script commit (scripts/ class). Codification batch with post-c7 docs per supervisor 17:19:32Z plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.