Skip to content

gh-149879: Fix test_httpservers on Cygwin#150417

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_httpservers
May 25, 2026
Merged

gh-149879: Fix test_httpservers on Cygwin#150417
vstinner merged 1 commit into
python:mainfrom
vstinner:test_httpservers

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented May 25, 2026

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 25, 2026
@vstinner
Copy link
Copy Markdown
Member Author

BaseHTTPSServerTestCase and test_https_client() still fail with this PR. But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

@vstinner
Copy link
Copy Markdown
Member Author

BaseHTTPSServerTestCase and test_https_client() still fail with this PR. But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

These tests pass with the ssl PR gh-150419.

@picnixz
Copy link
Copy Markdown
Member

picnixz commented May 25, 2026

But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

Disabling it seems a good way to fix the problems indeed. We need to investigate more the reason why SSL on cygwin is struggling before fixing each test one by one (I prefer having the big picture first because we may introduce subtle issues if we do a case-by-case)

@vstinner
Copy link
Copy Markdown
Member Author

Disabling it seems a good way to fix the problems indeed. We need to investigate more the reason why SSL on cygwin is struggling before fixing each test one by one (I prefer having the big picture first because we may introduce subtle issues if we do a case-by-case)

I changed my mind. It's no longer needed to disable the ssl module, since I have a working fix for ssl on Cygwin: PR gh-150419.

@vstinner vstinner enabled auto-merge (squash) May 25, 2026 19:41
@vstinner vstinner merged commit 71fa314 into python:main May 25, 2026
95 of 97 checks passed
@vstinner vstinner deleted the test_httpservers branch May 25, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants