gh-149571: Make Element.itertext consistent for Comment and ProcessingInstruction#149714
gh-149571: Make Element.itertext consistent for Comment and ProcessingInstruction#149714hardiksingh5864 wants to merge 6 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
StanFromIreland
left a comment
There was a problem hiding this comment.
It seems you ran a linter, causing a massive diff. Please revert the unrelated changes.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @StanFromIreland: please review the changes made to this pull request. |
|
@StanFromIreland please review the changes made to this pull request. |
|
Sorry I'm not an expert in these modules, I requested Serhiy. |
|
Don't rush. First we need to decide which behavior is more desirable. |
I’ll hold off on working on a fix until the expected behavior is clearer. Once confirmed about the desired behavior please share that to me as well |
This fixes a behavior mismatch between the pure-Python and C implementations of xml.etree.ElementTree.Element.itertext()
Added regression coverage in Lib/test/test_xml_etree.py