ipv6 check on number of octets missing #152

Activity

1. devikasondhi commented on Apr 11, 2020

   

   devikasondhi

   on Apr 11, 2020

   Author

   More actions

   Hello,

   This is a secondary check that you could add for cases having spaces (or other invalid characters):
   For instance, 2001:0000:1234: 0000:0000:C1C0:ABCD:0876 should be flagged as invalid due to a space character after the third octet.
2. devikasondhi commented on Apr 11, 2020

   

   devikasondhi

   on Apr 11, 2020 via email

   Last edited by devikasondhi

   Author

   More actions

   Here's a sample to reproduce the problem. I'm using v0.14.2.

   >> ipv6('2001:0000:1234: 0000:0000:C1C0:ABCD:0876')

   True

   …

   On Sat, Apr 11, 2020 at 6:09 PM mondeja ***@***.***> wrote: This is a secondary check that you could add for cases having spaces (or other invalid characters): For instance, 2001:0000:1234: 0000:0000:C1C0:ABCD:0876 should be flagged as invalid due to a space character after the third octet. I can't reproduce this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ5HBZTZ55J73N7LH6QW73RMBQJXANCNFSM4MF4EVTA> .

   -- Regards, Devika Sondhi PhD Scholar, IIIT-Delhi
3. GregIthaca commented on Aug 13, 2020

   

   GregIthaca

   on Aug 13, 2020

   More actions

   Also, at present MAC addresses are accepted as valid IPv6 addresses, which they are not.

   >>> validators.ip_address.ipv6('01:23:45:67:89:ab')
   True
   >>> validators.mac_address('01:23:45:67:89:ab')
   True
4. kvesteri commented on Aug 17, 2020

   

   kvesteri

   on Aug 17, 2020

   Collaborator

   More actions

   PRs welcome
5. hpfousac commented on Feb 22, 2022

   

   hpfousac

   on Feb 22, 2022

   More actions

   The issue is still there:

   root@node-api-f87467dcd-xbjc8:/# pip freeze | grep validators
   validators==0.18.2
   root@node-api-f87467dcd-xbjc8:/# python3
   Python 3.9.2 (default, Feb 28 2021, 17:03:44) 
   [GCC 10.2.1 20210110] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> import validators
   >>> 
   >>> validators.ip_address.ipv6 ("2001:1:40F")
   True
   >>> validators.ip_address.ipv6 ("2001:1:40Z")
   ValidationFailure(func=ipv6, args={'value': '2001:1:40Z'})
   >>> 
   

   Actually I'm using following construction to detect if IP address has correct format:

   import ipaddress # https://docs.python.org/3/library/ipaddress.html#module-ipaddress
   
   def IsIpv4 (str):
          try:
                  if 32 == ipaddress.ip_address (str).max_prefixlen:
                          return True
                  else:
                          return False
          except:
                  return False
    
   def IsIpv6 (str):
          try:
                  if 128 == ipaddress.ip_address(str).max_prefixlen:
                          return True
                  else:
                          return False
          except:
                  return False
    
    def IsIpAddr (str):
           return IsIpv4 (str) or IsIpv6 (str)
   
6. nandgator

   added

   bugIssue: Works not as designedIssue: Works not as designed

   outdatedIssue/PR: Open for more than 3 monthsIssue/PR: Open for more than 3 months

   maintenancePR: Alters existing source codePR: Alters existing source code

   on Mar 10, 2023
7. nandgator

   added 5 commits that reference this issue on Mar 10, 2023

   maint: improves `ip_address` module

   ...

   This issue will close once commit 39771fc is merged into the 'master' branch.

   39771fc

   maint: improves `ip_address` module

   ...

   This issue will close once commit 84e5f39 is merged into the 'master' branch.

   84e5f39

   maint: improves `ip_address` module

   ...

   This issue will close once commit 83bf2c2 is merged into the 'master' branch.

   83bf2c2

   maint: improves `ip_address` module

   ...

   This issue will close once commit 267c507 is merged into the 'master' branch.

   267c507

   maint: improves `ip_address` module

   ...

   This issue will close once commit e4f3adf is merged into the 'master' branch.

   e4f3adf
8. nandgator

   closed this as completedin #239on Mar 11, 2023