Skip to content

100.100.033.033 is validated as ipv4 #127

Closed as not planned
Closed as not planned

Description

@thestick613

It probably shouldn't be.

Activity

  1. ShivaShankerReddy commented on Dec 2, 2019

    @ShivaShankerReddy

    Hi @thestick613 ,

    Anything between 0-255.0-255.0-255.0-255 is considered as ipv4 address?

    Can you specify why it is not validated as ipv4.

    Regards,
    Shiva

  2. brl0 commented on Dec 2, 2019

    @brl0

    I too would have thought this should not be a valid address.
    Leading zeros are typically not used, but it seems that is by convention.
    Here are a couple of links discussing this:
    https://superuser.com/questions/857603/are-ip-addresses-with-and-without-leading-zeroes-the-same
    https://superuser.com/questions/929153/leading-zeros-in-ipv4-address-is-that-a-no-no-by-convention-or-standard

    If testing potentially random strings, I would not want to this to be valid.
    However, if testing an string that is expected to be an ip address, I might want to allow it as valid.

    Would it be possible to make a more strict ip address validator to does not allow leading zeros?

  3. added
    bugIssue: Works not as designed
    maintenancePR: Alters existing source code
    upstreamIssue: Changes expected in upstream
    on Mar 9, 2023
  4. nandgator commented on Mar 10, 2023

    @nandgator
    Collaborator

    ref #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue: Works not as designedmaintenancePR: Alters existing source codeupstreamIssue: Changes expected in upstream

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions