Improve numbering numId lookup#1553
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Author
|
Moved out of draft after local validation:
Timing sanity check on 5,000 contiguous IDs, isolating the membership loop:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #940.
CT_Numbering._next_numIdgathered existing IDs in a list, then checked membership for every candidate ID. When numbering definitions grow large and contiguous, that makes the lookup quadratic in the number of<w:num>elements.This changes the collection to a set so membership is constant-time while preserving the existing behavior of returning the first gap, starting at 1. I also added focused oxml tests for empty, contiguous, and gapped numbering definitions.
Local validation:
uv run --with pytest --with ruff --with-editable . python -m pytest tests/oxml/test_numbering.py -quv run --with pytest --with ruff --with-editable . python -m pytest tests/oxml/test_numbering.py tests/parts/test_numbering.py -quv run --with pytest --with ruff --with-editable . python -m ruff check src/docx/oxml/numbering.py tests/oxml/test_numbering.pygit diff --checkLocal timing sanity check on 5,000 contiguous IDs, isolating the membership loop:
0.387197s0.008164s