Improve error for mistaken self fixture - #14908
Open
meetpandya4715 wants to merge 1 commit into
Open
Conversation
meetpandya4715
marked this pull request as ready for review
August 19, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selfand pytest reports it as a missing fixtureThis addresses the maintainer-approved first case in #12907. It deliberately leaves the more complex missing-
selfmethod case unchanged.Why
The existing
fixture 'self' not foundmessage assumes the reader already understands pytest fixtures. For beginners who accidentally write a standalone test likedef test_something(self), a short hint points directly to the likely mistake without changing fixture discovery or execution.The hint is emitted only for the normal missing-fixture path when the unresolved name is exactly
self; recursive fixture dependency errors are unaffected.Validation
testing/python/fixtures.pymodule: 241 passed, 3 xfailedAI assistance
Codex assisted with issue research and implementation. I reviewed and understand the complete change and will own the contribution and follow-up discussion.