[7.4.x] fix #10447 - consider marks in reverse mro order to give base classes priority - #11545
Merged
Conversation
… classes priority
nicoddemus
approved these changes
Oct 24, 2023
nicoddemus
enabled auto-merge (squash)
October 24, 2023 14:44
cas--
added a commit
to cas--/Deluge
that referenced
this pull request
Feb 18, 2025
The Console UI tests started stalling after the realese of pytest 7.4.3
which was a result of the reversing the mro order of fixtures on
classes, to give base classes priority.
The change resulted in `base_fixture` being sorted before `client` and
`daemon` fixtures and the tests stalled, likely due to the use of yield
in base_fixture.
# pytest 7.4.2
[Mark(name='usefixtures', args=('client', 'daemon'), kwargs={})],
[Mark(name='usefixtures', args=('base_fixture',), kwargs={})],
# pytest 7.4.3
[Mark(name='usefixtures', args=('base_fixture',), kwargs={})],
[Mark(name='usefixtures', args=('client', 'daemon'), kwargs={})],
The fix is to move base_fixture along with the other fixtures and place it
last.
Refs: pytest-dev/pytest#11545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #11155 to 7.4.x branch. PR created by backport workflow.