Skip to content

Prepare release 7.4.2 - #11408

Merged
nicoddemus merged 1 commit into
7.4.xfrom
release-7.4.2
Sep 7, 2023
Merged

Prepare release 7.4.2#11408
nicoddemus merged 1 commit into
7.4.xfrom
release-7.4.2

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Created automatically from manual trigger.

Once all builds pass and it has been approved by one or more maintainers, the build
can be released by pushing a tag 7.4.2 to this repository.

@nicoddemus nicoddemus closed this Sep 7, 2023
@nicoddemus nicoddemus reopened this Sep 7, 2023
@nicoddemus

Copy link
Copy Markdown
Member

Waiting for someone else to approve the deploy job.

@bluetech

bluetech commented Sep 7, 2023

Copy link
Copy Markdown
Member

@nicoddemus I am a bit confused, when you trigger the deploy workflow, which branch do you use? I mean the "Use workflow from branch" here:

image

@nicoddemus

Copy link
Copy Markdown
Member

I have used 7.4.x for that.

@bluetech

bluetech commented Sep 7, 2023

Copy link
Copy Markdown
Member

OK. Shouldn't it rather be from the release-7.4.2 branch though, so it includes the "Prepare release version 7.4.2" commit? Maybe it doesn't matter?

In any case, would be good to explicitly mention which branch to use in RELEASING. Also the "the build can be released by pushing a tag 7.4.2 to this repository" message in the PR description needs an update.

@nicoddemus

Copy link
Copy Markdown
Member

Oh you are absolutely right. Let me cancel that and trigger the workflow again.

@nicoddemus

Copy link
Copy Markdown
Member

In any case, would be good to explicitly mention which branch to use in RELEASING. Also the "the build can be released by pushing a tag 7.4.2 to this repository" message in the PR description needs an update.

I will update those in main in a separate PR.

@nicoddemus

Copy link
Copy Markdown
Member

OK, now triggered deploy from release-7.4.2, thanks for catching that. 👍

@nicoddemus

Copy link
Copy Markdown
Member

Pushing the tag failed again. 😢

I will push the tag manually and try to fix the deploy job on main, and backport.

@nicoddemus
nicoddemus merged commit b0c4775 into 7.4.x Sep 7, 2023
@nicoddemus
nicoddemus deleted the release-7.4.2 branch September 7, 2023 18:47
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 7, 2023
Prepare release 7.4.2

(cherry picked from commit b0c4775)
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 7, 2023
As discussed in pytest-dev#11408:

* Improve documentation for the release process.
* Fix the description for the PRs created by the `prepare release pr` workflow.
* Fix pushing tag in the `deploy` workflow.
nicoddemus added a commit that referenced this pull request Sep 7, 2023
Prepare release 7.4.2

(cherry picked from commit b0c4775)
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 7, 2023
As discussed in pytest-dev#11408:

* Improve documentation for the release process.
* Fix the description for the PRs created by the `prepare release pr` workflow.
* Fix pushing tag in the `deploy` workflow.
nicoddemus added a commit that referenced this pull request Sep 8, 2023
As discussed in #11408:

* Improve documentation for the release process.
* Fix the description for the PRs created by the `prepare release pr` workflow.
* Fix pushing tag in the `deploy` workflow.
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 8, 2023
As discussed in pytest-dev#11408:

* Improve documentation for the release process.
* Fix the description for the PRs created by the `prepare release pr` workflow.
* Fix pushing tag in the `deploy` workflow.

(cherry picked from commit e5c81fa)
nicoddemus added a commit that referenced this pull request Sep 8, 2023
As discussed in #11408:

* Improve documentation for the release process.
* Fix the description for the PRs created by the `prepare release pr` workflow.
* Fix pushing tag in the `deploy` workflow.

(cherry picked from commit e5c81fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants