add longrepr from plugin tests - #50
Merged
Merged
Conversation
Member
|
@helpmefindaname I fixed CI in #51. Could you update this branch? |
Contributor
Author
|
Thanks for the fast response, I have updated the branch now |
utgwkk
approved these changes
Jul 2, 2022
Member
|
I have just published version 0.1.7 including this patch. Thank you for your contribution! @helpmefindaname |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the pytest reference
report.longreprcan be either a an object holding areprcrash, a tuple containingfilenamelinenumberandmessagein the respective order or a plain string containing a raw message.The latter is the way plugins like
pytest-flake8orpytest-mypyCreate their error messages. I propose adding the full context there, as only thereport.head_lineoritem.namecan lead to rather confusing outcomesI guess it would be even nicer to create multiple annotations per error, but then this plugin's code base would be too dependent on certain other plugins. Having the errors listed at the start of the file should be enough.