Added support for the Memcached getMulti setMulti and deleteMulti commands via the getMultiple setMultiple and deleteMultiple Cache methods#224
Conversation
…ool getMultiple method
…ltiple and deleteMultiple calls in the adapter
|
This class has all of this methods? take a look on https://github.com/php-cache/cache/blob/master/src/Adapter/Common/AbstractCachePool.php |
|
yeah but they're not actually doing the Multi commands which uses hte memcached api to send/get/delete multiple keys at a time, instead of emulating the ability as it does without the patch. If I were to send an array with 10000 entries it would have made 10000 requests whereas with the Memcached built in Multi functions it can be cut down to a single request. |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage ? 82.66%
Complexity ? 645
=========================================
Files ? 33
Lines ? 1621
Branches ? 0
=========================================
Hits ? 1340
Misses ? 281
Partials ? 0
Continue to review full report at Codecov.
|
…om deleteMulti logic when were on a version of memcached that does not have it [ <2.0.0 && >0.1.0 ]
…izing and unserializing data before setting and getting, improved the ttl handling a bit as well
Bumps the github_actions group with 1 update in the /.github/workflows directory: [shivammathur/setup-php](https://github.com/shivammathur/setup-php). Updates `shivammathur/setup-php` from 2 to 2.37.1 - [Release notes](https://github.com/shivammathur/setup-php/releases) - [Commits](shivammathur/setup-php@v2...2.37.1) --- updated-dependencies: - dependency-name: shivammathur/setup-php dependency-version: 2.37.1 dependency-type: direct:production dependency-group: github_actions ... Signed-off-by: dependabot[bot] <support@github.com>
Configure WhiteSource Bolt for GitHub
…b/workflows/github_actions-636cd4b091 Bump shivammathur/setup-php from 2 to 2.37.1 in /.github/workflows in the github_actions group across 1 directory
Description
Not sure if this is the best way to do this and the getMutliple method needs a bit of tweaking for the 1 assertion that fails.
TODO