Skip to content

test: gc before test-memory-usage baseline#63214

Closed
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-test-memory-usage-gc-baseline
Closed

test: gc before test-memory-usage baseline#63214
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-test-memory-usage-gc-baseline

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented May 9, 2026

Call gc() before taking the test-memory-usage baseline so stale ArrayBuffer backing stores are cleared before the strict delta check.

This keeps the exact 10 MiB assertion while avoiding unrelated cleanup between snapshots.

Fixes: #63210

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 9, 2026
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@inoway46 inoway46 force-pushed the fix-test-memory-usage-gc-baseline branch from 49474c3 to b83d76c Compare May 9, 2026 16:14
@inoway46 inoway46 marked this pull request as ready for review May 9, 2026 16:17
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (bbf51ad) to head (b83d76c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63214      +/-   ##
==========================================
- Coverage   90.03%   90.03%   -0.01%     
==========================================
  Files         713      713              
  Lines      224950   224950              
  Branches    42532    42537       +5     
==========================================
- Hits       202542   202535       -7     
- Misses      14175    14186      +11     
+ Partials     8233     8229       -4     

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inoway46
Copy link
Copy Markdown
Contributor Author

inoway46 commented May 9, 2026

It looks like this change was not sufficient to fully fix the flaky failure.

The fedora-latest-x64 run failed on the same exact-size assertion: https://ci.nodejs.org/job/node-test-commit-linux/69926/nodes=fedora-latest-x64/

@inoway46
Copy link
Copy Markdown
Contributor Author

Closing this since the GC-before-baseline approach still failed in CI. I'll try relaxing the arrayBuffers assertion in a separate PR.

@inoway46 inoway46 closed this May 10, 2026
@inoway46 inoway46 deleted the fix-test-memory-usage-gc-baseline branch May 10, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-memory-usage failing on Windows

2 participants