esm: improve performance & tidy tests#43784
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This standardises the setup of ESM tests and improves performance by parallelising case runs using a promise wrapper around async spawn.
I originally started out using chaining for parallelisation, but switched to
node:testto avoid a bajillion.then()s. As.then()s, the performance improvement was obvious.I'm not sure how to get a truly apples-to-apples comparison:
./tools/test.py -J es-moduledoesn't benefit fromnode:test's parallelisation. I manually checked one of the largest tests, and the improvement is quite stark:$> time ./node ./test/es-module/test-esm-loader-chaining.mjs0m1.168s0m0.442sNote to reviewers: enabling
Hide whitespacereduces the diff by about a third.cc @nodejs/loaders