Skip to content

PYTHON-6248 Enable ruff FLY rules - #3208

Merged
NoahStapp merged 4 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6248
Nov 11, 2026
Merged

NoahStapp merged 4 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6248

Conversation

@NoahStapp

Copy link
Copy Markdown
Contributor

PYTHON-6248

Changes in this PR

Enable ruff's FLY linting rules and make the necessary code changes to have them pass.

Test Plan

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@NoahStapp
NoahStapp requested a review from a team as a code owner November 11, 2026 18:37
@NoahStapp
NoahStapp requested review from aclark4life and a balanced review from Copilot November 11, 2026 18:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Ruff FLY rule enablement and encryption-test formatting updates.

No open issues 🎉

What changed in this PR

Enables Ruff’s FLY rules and updates encryption-test string formatting to comply.

Changes:

  • Removes FLY from Ruff’s ignored rule families.
  • Replaces key-vault namespace joins with f-strings in asynchronous tests and their generated synchronous counterparts.
File Description
test/​test_encryption.py Mirrors the namespace formatting changes in synchronous tests.
test/​asynchronous/​test_encryption.py Uses f-strings for explicit and automatic encryption key-vault namespaces.
pyproject.toml Removes the FLY rule-family exclusion.

Review effort: Balanced

@NoahStapp
NoahStapp merged commit 48b6246 into mongodb:main Nov 11, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants