Skip to content

PYTHON-6247 Enable ruff ISC rules - #3207

Merged
NoahStapp merged 2 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6247
Nov 11, 2026
Merged

NoahStapp merged 2 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6247

Conversation

@NoahStapp

Copy link
Copy Markdown
Contributor

PYTHON-6247

Changes in this PR

Enable ruff's ISC linting rules. No changes are required to pass the checks.

Test Plan

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@NoahStapp
NoahStapp requested a review from a team as a code owner November 11, 2026 18:35
@NoahStapp
NoahStapp requested review from sleepyStick and a balanced review from Copilot November 11, 2026 18:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with the change enabling Ruff’s implicit string concatenation checks.

No open issues 🎉

What changed in this PR

Enables Ruff’s implicit string concatenation (ISC) rules in PyMongo’s lint configuration. No application code changes are included.

Changes:

  • Removes ISC from Ruff’s ignored rule groups.
File Description
pyproject.toml Enables checks for implicit string concatenation by removing the ISC exclusion.

Review effort: Balanced

sleepyStick
sleepyStick previously approved these changes Nov 11, 2026
@NoahStapp
NoahStapp merged commit 84ccf88 into mongodb:main Nov 11, 2026
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants