Repository navigation
fix(auto): preserve optional speaker dependency errors - #3819
Merged
Merged
Conversation
Integrate the reviewed #3788 fix and unchanged regression tests on current main, with both NumPy CI selections. Co-authored-by: monsterlag <64719697+monsterlag@users.noreply.github.com> Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This was referenced Nov 1, 2026
LauraGPT
added a commit
that referenced
this pull request
Nov 2, 2026
Deliver the merged optional speaker dependency diagnostic fix (#3819). Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
Merged
LauraGPT
added a commit
that referenced
this pull request
Nov 2, 2026
Deliver the tested optional speaker dependency diagnostic fix (#3819). Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates @monsterlag's #3788 onto current main without changing the contributor's fork. Preserve the original optional speaker-import exception and raise an actionable chained ImportError only when speaker construction is requested. ASR-only use remains available. The original ten regression cases are unchanged; both NumPy CI matrices now select them and trigger on their path.
This is an error-reporting fix related to #2546, not evidence that its unidentified Windows dependency failure is resolved. That issue remains open. The original PR's old potential-merge tree did not include current main; it is not used as acceptance evidence.
Validation
test_auto_model_ncpu.py::test_the_cap_actually_reduces_blas_worksegfaults in SciPy eigh after setting 192 threads on both untouched current main and this candidate. The initial combined 375-case process returned -11 and produced no completed XML; that failure is retained, not counted as a pass. This pre-existing native performance problem is not fixed here and is not part of the existing CI selection.Original contribution is credited in the signed+DCO commit. #3788 will be closed as superseded only after final integration acceptance, not described as a merged original commit.