Skip to content

fix(node): remove unused request listener and context - #3181

Open
bbdu3 wants to merge 1 commit into
modelcontextprotocol:mainfrom
bbdu3:fix/remove-unuesd-variable
Open

bbdu3 wants to merge 1 commit into
modelcontextprotocol:mainfrom
bbdu3:fix/remove-unuesd-variable

Conversation

@bbdu3

@bbdu3 bbdu3 commented Nov 13, 2026 •

Copy link
Copy Markdown

What this PR does / why we need it

Remove unused _requestListener and _requestContext fields

These private fields were initialized in the constructor but never used.
The handleRequest() method already creates its own handler per request, passing auth and body through closures directly.

Signed-off-by: bbdu3 <ergouyang854@gmail.com>
@bbdu3
bbdu3 requested a review from a team as a code owner November 13, 2026 04:47
@changeset-bot

changeset-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4e0ba6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Nov 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@3181

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@3181

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@3181

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@3181

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@3181

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@3181

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@3181

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@3181

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@3181

commit: 4e0ba6b

@claude claude Bot added the v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes label Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant