fix: validate full sampling tool result history#2622
Open
Epochex wants to merge 1 commit into
Open
Conversation
Code ReviewPR: fix: validate full sampling tool result history by @Epochex
Wallet: Code review for MCP Python SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_tool_use_result_messagesonly checked the last message pair. If an earliertool_resultwas malformed or did not match the previoustool_use, a later plain message made validation pass and the invalid history could still be sent to the sampling client.This changes the validator to walk the whole message history and require every
tool_usemessage to be followed by matchingtool_resultblocks.Tests
uv run ruff check .uv run ruff format --check .uv run pyright --pythonplatform Linuxuv run pytest -q