Skip to content

Upgrade vscode-nls-dev module. Add translation hints for strings containing markdown - #7620

Merged
Colengms merged 2 commits into
mainfrom
coleng/new_vscode-nls-dev
May 28, 2021
Merged

Upgrade vscode-nls-dev module. Add translation hints for strings containing markdown#7620
Colengms merged 2 commits into
mainfrom
coleng/new_vscode-nls-dev

Conversation

@Colengms

Copy link
Copy Markdown
Contributor

Support for translation hints (comments) have been added to the latest vscode-nls-dev.

This does not yet localize the Getting Started walkthough. We anticipate significant changes to the walkthrough in 1.5.0, so I don't want to make those strings localizable just yet. (Also, I need to finish #7538 )

@Colengms Colengms changed the title Upgrade vscode-nls-dev modules. Add translation hints for strings containing markdown Upgrade vscode-nls-dev module. Add translation hints for strings containing markdown May 28, 2021
@Colengms
Colengms merged commit f973792 into main May 28, 2021
@Colengms
Colengms deleted the coleng/new_vscode-nls-dev branch May 28, 2021 20:22
@sean-mcmanus sean-mcmanus mentioned this pull request Jun 14, 2021
@sean-mcmanus

Copy link
Copy Markdown
Contributor

@Colengms This PR appears to break the settings UI so I had to undo it: #7694

@Colengms

Copy link
Copy Markdown
Contributor Author

@Colengms This PR appears to break the settings UI so I had to undo it: #7694

Could you elaborate? What was the exception? Since the strings were getting properly extracted in the export XLF, the problem would seem to be in vscode-nls, so we need to open a bug against that, if so.

@sean-mcmanus

Copy link
Copy Markdown
Contributor

@Colengms Details are in the email I sent.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants