Remove VSTHRD003 warnings for readonly tasks defined in another assembly - #574
Merged
Merged
Conversation
There were some cases where the syntax reference isn't available in source at all, and we were mistakenly reporting the warning in that case.
David Kean (davkean)
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tried to avoid reporting VSTHRD003 diagnostics for readonly Task fields defined in other projects/assemblies, but failed to do so properly. This fixes that to dramatically reduce false warnings typically associated with precompleted tasks such as
SpecialTasks.TrueTask.It also refines the wording in the diagnostic to reduce confusion.