Skip to content

Check all [Flags] enums for overlaps #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dahlbyk wants to merge 1 commit into from
Closed

Check all [Flags] enums for overlaps #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions LibGit2Sharp.Tests/MetaFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,25 @@ public void TypesInLibGit2SharpMustBeExtensibleInATestingContext()
}
}

[Fact]
public void EnumsWithFlagsHaveMutuallyExclusiveValues()
{
var flagsEnums = Assembly.GetAssembly(typeof(Repository)).GetExportedTypes()
.Where(t => t.IsEnum && t.GetCustomAttributes(typeof(FlagsAttribute), false).Any());

var overlaps = from t in flagsEnums
from int x in Enum.GetValues(t)
where x != 0
from int y in Enum.GetValues(t)
where y != 0
where x != y && (x & y) == y
select string.Format("{0}.{1} overlaps with {0}.{2}", t.Name, Enum.ToObject(t, x), Enum.ToObject(t, y));

var message = string.Join(Environment.NewLine, overlaps.ToArray());

Assert.Equal("", message);
}

private string BuildMissingDebuggerDisplayPropertyMessage(IEnumerable<Type> typesWithDebuggerDisplayAndInvalidImplPattern)
{
var sb = new StringBuilder();
Expand Down
15 changes: 0 additions & 15 deletions LibGit2Sharp.Tests/StatusFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,6 @@ namespace LibGit2Sharp.Tests
{
public class StatusFixture : BaseFixture
{
[Fact]
public void FileStatusFlagsAreMutuallyExclusive()
{
var overlaps = from FileStatus x in Enum.GetValues(typeof(FileStatus))
where x != default(FileStatus)
from FileStatus y in Enum.GetValues(typeof(FileStatus))
where y != default(FileStatus)
where x != y && (x & y) == y
select string.Format("{0} overlaps with {1}", x, y);

var message = string.Join(Environment.NewLine, overlaps.ToArray());

Assert.Equal("", message);
}

[Fact]
public void CanRetrieveTheStatusOfAFile()
{
Expand Down